add pool service controller. #2010

zyjhtangtang · 2024-04-08T11:30:04Z

What type of PR is this?

/kind feature
/sig network

What this PR does / why we need it:

The first-level controller for the multi-region load balancer.

Does this PR introduce a user-facing change?

YES

codecov · 2024-04-08T11:36:06Z

Codecov Report

Attention: Patch coverage is 73.75000% with 147 lines in your changes are missing coverage. Please review.

Project coverage is 55.24%. Comparing base (839a52a) to head (1df5657).
Report is 1 commits behind head on master.

Files	Patch %	Lines
...rset/loadbalancerset/loadbalancerset_controller.go	65.88%	60 Missing and 27 partials ⚠️
...oller/loadbalancerset/loadbalancerset/predicate.go	75.38%	16 Missing and 16 partials ⚠️
...ler/loadbalancerset/loadbalancerset/annotations.go	79.48%	8 Missing and 8 partials ⚠️
...r/loadbalancerset/loadbalancerset/event_handler.go	83.56%	9 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   54.71%   55.24%   +0.53%     
==========================================
  Files         177      183       +6     
  Lines       17271    17831     +560     
==========================================
+ Hits         9450     9851     +401     
- Misses       6849     6953     +104     
- Partials      972     1027      +55

Flag	Coverage Δ
unittests	`55.24% <73.75%> (+0.53%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zyjhtangtang · 2024-04-09T06:05:54Z

/rerun

pkg/yurtmanager/controller/poolservice/predicate.go

rambohe-ch · 2024-04-11T02:18:33Z

@zyjhtangtang I think the repo of controllers about MultiPoolLoadBalancer should be constructed as following:

controller:
|
-- loadbalancerset:
   |
   -- loadbalancerset:
   |
   -- enslb:
   | 
   -- viplb:

zyjhtangtang · 2024-04-11T05:41:15Z

@zyjhtangtang I think the repo of controllers about MultiPoolLoadBalancer should be constructed as following:
controller:
|
-- loadbalancerset:
   |
   -- loadbalancerset:
   |
   -- enslb:
   | 
   -- viplb:

Thanks for the suggestion, I have adjusted the relevant directory structure

pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/localbalancerset_controller.go

pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/finalizer.go

pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/localbalancerset_controller.go

pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/localbalancerset_controller_test.go

pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/event_handler.go

pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/loadbalancerset_controller.go

sonarqubecloud · 2024-04-12T03:49:28Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

rambohe-ch · 2024-04-12T06:25:32Z

/lgtm

zyjhtangtang force-pushed the master branch from de158e6 to cd9ed01 Compare April 9, 2024 02:07

River-sh reviewed Apr 9, 2024

View reviewed changes

zyjhtangtang force-pushed the master branch 6 times, most recently from 3b23093 to 8422050 Compare April 11, 2024 04:05